pci: add pci device support in dbs-cli #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Wu <[email protected]>
justxuewei
reviewed
Jan 18, 2024
README.md
Outdated
|
|
||
| You can choose to attach a pci device during the boot time of Dragonball. | ||
| ``` | ||
| ./dbs-cli create --log-file $LOG_FILE --log-level $LOG_LEVEL --kernel-path $KERNEL_PATH --rootfs $ROOTFS_PATH --boot-args "console=ttyS0 tty0 reboot=k debug panic=1 root=/dev/vda1" --hostdev-id $HOST_DEVICE_ID --sysfs-path $SYSFS_PATH --bus-slot-func $BUS_SLOT_FUNC --vendor-device-id $VENDOR_DEVICE_ID |
There was a problem hiding this comment.
Could you give an example of how to acquire those values? For example:
Get Xxxxxx's hostdev-id by lspci
$ lspci
02:00.0 Xxxxxx
$ HOST_DEVICE_ID="02:00.0"I think leaving the part of adding PCI device is enough. Otherwise, it looks too complicated to read.
--hostdev-id $HOST_DEVICE_ID \
--sysfs-path $SYSFS_PATH \
--bus-slot-func $BUS_SLOT_FUNC \
--vendor-device-id $VENDOR_DEVICE_ID
src/cli_instance.rs
Outdated
| @@ -153,6 +157,31 @@ impl CliInstance { | |||
| .expect("failed to set vsock socket path"); | |||
| } | |||
|
|
|||
| if !args.host_device.hostdev_id.is_none() { | |||
There was a problem hiding this comment.
Suggested change
| if !args.host_device.hostdev_id.is_none() { | |
| if let Some(hostdev_id) = args.host_device.hostdev_id { |
There was a problem hiding this comment.
actually this is for checking whether user provide hostdev_id and bus_slot_func in the command line (which are the must parameters) and I was being lazy to just check one of the parameters......
I have completed this part and also added a comment above.
src/cli_instance.rs
Outdated
Comment on lines
163
to
167
| hostdev_id: args | ||
| .host_device | ||
| .hostdev_id | ||
| .expect("There has to be hostdev_id if you want to add host device."), |
There was a problem hiding this comment.
Suggested change
| hostdev_id: args | |
| .host_device | |
| .hostdev_id | |
| .expect("There has to be hostdev_id if you want to add host device."), | |
| hostdev_id, |
studychao
force-pushed
the
pci
branch
2 times, most recently
from
7413e45 to
12b8357
Compare
1. attach pci device during the boot time of Dragonball. 2. hot plug pci device when the Dragonball is running. 3. prepare to hot unplug pci device when the Dragonball is running. 4. hot unplug pci device when the Dragonball is running. fixes: openanolis#29 Signed-off-by: Chao Wu <[email protected]>
justxuewei
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #29